Skip to content

Commit

Permalink
increase some timeouts (#3872)
Browse files Browse the repository at this point in the history
Signed-off-by: Modular Magician <magic-modules@google.com>
  • Loading branch information
modular-magician authored and danawillow committed Jun 18, 2019
1 parent c9ddd0c commit 12cb435
Show file tree
Hide file tree
Showing 8 changed files with 31 additions and 25 deletions.
6 changes: 3 additions & 3 deletions google/resource_compute_instance.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ func resourceComputeInstance() *schema.Resource {
MigrateState: resourceComputeInstanceMigrateState,

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(6 * time.Minute),
Update: schema.DefaultTimeout(6 * time.Minute),
Delete: schema.DefaultTimeout(6 * time.Minute),
Create: schema.DefaultTimeout(20 * time.Minute),
Update: schema.DefaultTimeout(20 * time.Minute),
Delete: schema.DefaultTimeout(20 * time.Minute),
},

// A compute instance is more or less a superset of a compute instance
Expand Down
2 changes: 1 addition & 1 deletion google/resource_container_cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ func resourceContainerCluster() *schema.Resource {

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(30 * time.Minute),
Update: schema.DefaultTimeout(30 * time.Minute),
Update: schema.DefaultTimeout(60 * time.Minute),
Delete: schema.DefaultTimeout(30 * time.Minute),
},

Expand Down
6 changes: 3 additions & 3 deletions google/resource_dataproc_cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ func resourceDataprocCluster() *schema.Resource {
Delete: resourceDataprocClusterDelete,

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(15 * time.Minute),
Update: schema.DefaultTimeout(5 * time.Minute),
Delete: schema.DefaultTimeout(5 * time.Minute),
Create: schema.DefaultTimeout(20 * time.Minute),
Update: schema.DefaultTimeout(20 * time.Minute),
Delete: schema.DefaultTimeout(20 * time.Minute),
},

Schema: map[string]*schema.Schema{
Expand Down
6 changes: 3 additions & 3 deletions google/resource_sql_database_instance.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ func resourceSqlDatabaseInstance() *schema.Resource {
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(10 * time.Minute),
Update: schema.DefaultTimeout(10 * time.Minute),
Delete: schema.DefaultTimeout(10 * time.Minute),
Create: schema.DefaultTimeout(20 * time.Minute),
Update: schema.DefaultTimeout(20 * time.Minute),
Delete: schema.DefaultTimeout(20 * time.Minute),
},

CustomizeDiff: customdiff.All(
Expand Down
12 changes: 9 additions & 3 deletions website/docs/r/compute_instance.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,6 @@ The following arguments are supported:
packets with non-matching source or destination IPs.
This defaults to false.

* `create_timeout` - (Optional) Configurable timeout in minutes for creating instances. Default is 4 minutes.
Changing this forces a new resource to be created.

* `description` - (Optional) A brief description of this resource.

* `deletion_protection` - (Optional) Enable deletion protection on this instance. Defaults to false.
Expand Down Expand Up @@ -348,6 +345,15 @@ exported:
encoded SHA-256 hash of the [customer-supplied encryption key]
(https://cloud.google.com/compute/docs/disks/customer-supplied-encryption) that protects this resource.

## Timeouts

This resource provides the following
[Timeouts](/docs/configuration/resources.html#timeouts) configuration options:

- `create` - Default is 20 minutes.
- `update` - Default is 20 minutes.
- `delete` - Default is 20 minutes.

## Import

~> **Note:** The fields `boot_disk.0.disk_encryption_raw` and `attached_disk.*.disk_encryption_key_raw` cannot be imported automatically. The API doesn't return this information. If you are setting one of these fields in your config, you will need to update your state manually after importing the resource.
Expand Down
9 changes: 4 additions & 5 deletions website/docs/r/container_cluster.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -629,15 +629,14 @@ exported:
notation (e.g. `1.2.3.4/29`). Service addresses are typically put in the last
`/16` from the container CIDR.

<a id="timeouts"></a>
## Timeouts

`google_container_cluster` provides the following
This resource provides the following
[Timeouts](/docs/configuration/resources.html#timeouts) configuration options:

- `create` - (Default `30 minutes`) Used for clusters
- `update` - (Default `30 minutes`) Used for updates to clusters
- `delete` - (Default `30 minutes`) Used for destroying clusters.
- `create` - Default is 30 minutes.
- `update` - Default is 60 minutes.
- `delete` - Default is 30 minutes.

## Import

Expand Down
9 changes: 5 additions & 4 deletions website/docs/r/dataproc_cluster.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -471,11 +471,12 @@ exported:
* `cluster_config.0.software_config.0.properties` - A list of the properties used to set the daemon config files.
This will include any values supplied by the user via `cluster_config.software_config.override_properties`


## Timeouts

`google_dataproc_cluster` provides the following
This resource provides the following
[Timeouts](/docs/configuration/resources.html#timeouts) configuration options:

- `create` - (Default `10 minutes`) Used for creating clusters.
- `update` - (Default `5 minutes`) Used for updating clusters
- `delete` - (Default `5 minutes`) Used for destroying clusters.
- `create` - Default is 20 minutes.
- `update` - Default is 20 minutes.
- `delete` - Default is 20 minutes.
6 changes: 3 additions & 3 deletions website/docs/r/sql_database_instance.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -399,9 +399,9 @@ performing filtering in a Terraform config.
`google_sql_database_instance` provides the following
[Timeouts](/docs/configuration/resources.html#timeouts) configuration options:

- `create` - Default is 10 minutes.
- `update` - Default is 10 minutes.
- `delete` - Default is 10 minutes.
- `create` - Default is 20 minutes.
- `update` - Default is 20 minutes.
- `delete` - Default is 20 minutes.

## Import

Expand Down

0 comments on commit 12cb435

Please sign in to comment.