Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect breaking changes in PRs #10923

Closed
c2thorn opened this issue Jan 18, 2022 · 2 comments
Closed

Detect breaking changes in PRs #10923

c2thorn opened this issue Jan 18, 2022 · 2 comments
Assignees
@ScottSuarez
Labels
enhancement mmv1-generator Provider-wide changes to resource templates or other generator changes size/l technical-debt
Milestone
Near-Term Goals

Comments

@c2thorn
Copy link
Collaborator

c2thorn commented Jan 18, 2022 •
edited
Loading

To both reduce the amount of maintainer effort required for PRs and add another layer of protection, we can automatically detect breaking changes in resource schema.
Likely, we can utilize #10922 as a step towards this.
@rileykarson rileykarson added mmv1-generator Provider-wide changes to resource templates or other generator changes technical-debt size/l labels Jan 18, 2022
@rileykarson rileykarson added this to the Near-Term Goals milestone Jan 18, 2022
@ScottSuarez
Copy link
Collaborator

closed with GoogleCloudPlatform/magic-modules#6642

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ScottSuarez ScottSuarez

Labels
enhancement mmv1-generator Provider-wide changes to resource templates or other generator changes size/l technical-debt
Projects
None yet
Milestone
Near-Term Goals
Development

No branches or pull requests
3 participants
@rileykarson @ScottSuarez @c2thorn