-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
communicate breaking changes to the user #6642
communicate breaking changes to the user #6642
Conversation
tested in #6609 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handing off review, I'm a little underwater already and not the strongest w/ bash. Couple minor thoughts on first glance.
Co-authored-by: Riley Karson <rileykarson@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tentatively seems reasonable, and I'm fine with going ahead with it. However, please be sure to test thoroughly post-deploy.
go/magician-breaking-change
implements magician breaking change detection and communication for any and all contributors.
Release Note Template for Downstream PRs (will be copied)