Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

communicate breaking changes to the user #6642

Conversation

ScottSuarez
Copy link
Contributor

go/magician-breaking-change

implements magician breaking change detection and communication for any and all contributors.

Release Note Template for Downstream PRs (will be copied)


@ScottSuarez ScottSuarez requested a review from melinath October 4, 2022 21:26
@ScottSuarez
Copy link
Contributor Author

tested in #6609

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handing off review, I'm a little underwater already and not the strongest w/ bash. Couple minor thoughts on first glance.

.ci/containers/github-differ/Dockerfile Show resolved Hide resolved
.ci/containers/github-differ/generate_comment.sh Outdated Show resolved Hide resolved
@rileykarson rileykarson requested a review from melinath October 5, 2022 17:21
Co-authored-by: Riley Karson <rileykarson@google.com>
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tentatively seems reasonable, and I'm fine with going ahead with it. However, please be sure to test thoroughly post-deploy.

.ci/containers/github-differ/compare_breaking_changes.sh Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants