Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all resources authoritative #1167

Closed
8 tasks done
paddycarver opened this issue Mar 8, 2018 · 3 comments
Closed
8 tasks done

Make all resources authoritative #1167

paddycarver opened this issue Mar 8, 2018 · 3 comments
Assignees
Milestone

Comments

@paddycarver
Copy link
Contributor

paddycarver commented Mar 8, 2018

Early versions of the Google provider had resources that tried to respect changes made outside of Terraform, instead of overwriting them. Later versions introduced an authoritative field that would turn this behavior off, overwriting changes outside Terraform. Both of these behaviors should be removed, so all resources just overwrite changes outside of Terraform, as that is how Terraform is meant to function. This issue is to collect the list of resources with the previous behaviors so that we can track updating them.

  • google_compute_instance.metadata
  • google_compute_project_metadata
  • google_sql_database_instance
  • google_compute_url_map - MM?
  • google_storage_object_acl.role_entity
  • google_project_iam_policy
  • google_cloudiot_registry - maybe
  • google_storage_default_object_acl.role_entity
@paddycarver paddycarver added this to the 2.0.0 milestone Mar 8, 2018
@danawillow
Copy link
Contributor

danawillow commented Apr 12, 2018

Found another! google_compute_instance.metadata is not authoritative (this one might be tricky since I assume metadata may get added out of band by gcp itself (this should be verified though))

@rileykarson
Copy link
Collaborator

🎉

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants