Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform: Make google_project_iam_policy authoritative. #581

Conversation

rileykarson
Copy link
Member

@rileykarson rileykarson commented Oct 17, 2018

Part of hashicorp/terraform-provider-google#1167, hashicorp/terraform-provider-google#1203

Remove the getProject feature - policy is really really dangerous now and users probably do not want to use this resource on their primary/provider project, so let's make them explicitly specify it if they do.

Depends on hashicorp/terraform-provider-google#2257

@paddycarver


[all]

[terraform]

Make google_project_iam_policy authoritative.

[terraform-beta]

[puppet]

[puppet-bigquery]

[puppet-compute]

[puppet-container]

[puppet-dns]

[puppet-logging]

[puppet-pubsub]

[puppet-resourcemanager]

[puppet-sql]

[puppet-storage]

[chef]

[chef-compute]

[chef-container]

[chef-dns]

[chef-logging]

[chef-spanner]

[chef-sql]

[chef-storage]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!
I checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.

Once this PR is approved, you can feel free to merge it without taking any further steps.

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#13

@rileykarson rileykarson force-pushed the project-iam-policy-auth branch from 36f002b to ace890a Compare October 19, 2018 20:31
@rileykarson rileykarson force-pushed the project-iam-policy-auth branch from ace890a to d04a30d Compare October 19, 2018 21:29
@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 2687268) have been included in your existing downstream PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants