Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuration of Memorystore Redis #1547

Closed
pdecat opened this issue May 28, 2018 · 3 comments
Closed

Support configuration of Memorystore Redis #1547

pdecat opened this issue May 28, 2018 · 3 comments
Labels

Comments

@pdecat
Copy link
Contributor

pdecat commented May 28, 2018

#1485 added support for the creation of Memorystore Redis instances but left apart the redis_configs block which allows to configure maxmemory-policy and notify-keyspace-events parameters.

https://cloud.google.com/memorystore/docs/redis/reference/rest/v1beta1/projects.locations.instances#Instance.FIELDS.redis_configs

Terraform Version

# terraform version
Terraform v0.11.7
+ provider.external v1.0.0
+ provider.google v1.13.0
+ provider.template v1.0.0

Affected Resource(s)

  • google_redis_instance

Terraform Configuration Files

resource "google_redis_instance" "test" {
  name           = "test"
  memory_size_gb = 1

  # NOT IMPLEMENTED YET
  redis_configs {
    maxmemory_policy = "allkeys-lru"
    notify_keyspace_events = "KEA"
  }
}

Expected Behavior

I'd expect the redis_configs block to be supported.

Actual Behavior

The redis_configs block to be supported.

@afomera
Copy link

afomera commented May 31, 2018

Oh man, thanks for submitting this issue. I had spent an hour attempting to see if there had been some magical way to do it that hadn't been documented.

Sidenote: couple other things I tried when trying to create the changes: metadata, redis_configs, redisConfigs, redis_configurations.

Sadly, I have no experience in Go and it looks above me for implementing this right now, so I have to just give my thanks in advance for anyone who picks this up.

@edevil
Copy link

edevil commented Jun 30, 2018

PR is #1706

danawillow pushed a commit that referenced this issue Jul 2, 2018
<!-- This change is generated by MagicModules. -->
/cc @edevil 

Fixes #1547
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this issue Nov 9, 2018
<!-- This change is generated by MagicModules. -->
/cc @edevil 

Fixes hashicorp#1547
@ghost
Copy link

ghost commented Nov 17, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 17, 2018
@github-actions github-actions bot added forward/review In review; remove label to forward service/redis-instance labels Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants