Fix intermittent formatting issue with VCR test reports

[melinath]

What kind of contribution is this issue about?

Pull request UX

Details

Something about the way we're doing color formatting has a glitch that causes it to not always display properly.

We should try to find a way to make this more consistent (which may require moving this output to a check, or removing the color formatting.)

References

GoogleCloudPlatform/magic-modules#11272 (comment)

[roaks3]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerCluster_withInsecureKubeletReadonlyPortEnabledInNodeConfigUpdates[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

[roaks3]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetappVolume_autoTieredNetappVolumeExample_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetappStoragePool_autoTieredStoragePoolCreateExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[roaks3]

The above comment is now rendering fine after pasting here, and on the original PR, but it initially rendered as:

[roaks3]

Note: this seems to be due to some sort of MathML/Latex issue, where the same content in the comment can be rendered with different html sometimes. I can't find any recent issues being raised about this, but it's possible we want to move away from this solution for rendering color/font to get more consistent results.

[melinath]

We could potentially use alerts: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts

[wyardley]

The above comment is now rendering fine after pasting here, and on the original PR, but it initially rendered as:

I noticed this as well, where it would render weird and then show up properly later on the same comment.

Thanks for working on some changes towards fixing this, @melinath!

[melinath]

See github/markup#1440, https://github.com/orgs/community/discussions/31570, and github/markup#369 for discussion about the different options for "color" in markdown. After consideration, I'm opting for emoji-based emphasis because I don't think the benefit is worth the effort of implementing an image rendering website. Alert coloring would work for actual alerts, but these aren't actually alerts.

[wyardley]

I'm glad they're color emojis and not like "Tests failed during recording mode 👎👎"

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.