Add support to associate a vlan_attachment to a router-interface

[netturpin]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Based on GCP documentation, there are 4 steps to get a complete setup :
1 Request a Partner/Dedicated Interconect (out of scope as mention in issue #1140 )
2. Create a vlan attachment (solved with #1569)
3. Associate a vlan attachment with a cloud router by creating a router interface linked to the vlan attachment
4. Setup a BGP session between the Cloud router and the on-prem router.

My understanding is, now that we are able to create vlan attachment in terraform, we need the ability to specify them when we create a router_interface. I feel this should be done in google_compute_router_interface object but I may be wrong,

The BGP session setup should be already functional with the compute_router_peer object.

New or Affected Resource(s)

• google_compute_router_interface

Potential Terraform Configuration

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.
resource "google_compute_router_interface" "foobar" {
  name       = "interface-1"
  router     = "router-1"
  region     = "us-central1"
  ip_range   = "169.254.1.1/30"
  vlan_attachment = "attachment-1"
}

References

• Add support for Interconnect VLAN attachments #1140

[morgante]

Along with this, the "cloudRouterIpAddress" field needs to be exposed as an output from an interconnect attachment: https://cloud.google.com/compute/docs/reference/rest/v1/interconnectAttachments/get

[morgante]

@tysen Have we also addressed this comment as well?

[tysen]

Sure have.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!