Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add interconnect attachments. Fixes #1140. #1569

Merged
merged 1 commit into from
Sep 21, 2018

Conversation

modular-magician
Copy link
Collaborator

@modular-magician modular-magician commented May 31, 2018

/cc @ndmckinley

Fixes #1140.

@nat-henderson
Copy link
Contributor

This has finally been tested! Ready to go in!

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might make sense also to include a test file that has nothing in it except a comment saying why we don't have tests for this.

Required: true,
ForceNew: true,
},
"name": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can probably have a ValidateFunc

},
"region": {
Type: schema.TypeString,
Required: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional

resource "google_compute_interconnect_attachment" "default" {
name = "test-interconnect"
interconnect = "https://googleapis.com/compute/v1/projects/.../global/interconnects/..."
router = "https://googleapis.com/compute/v1/projects/.../regions/.../routers/..."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be the self link of a router resource. Not sure what to do about the interconnect one, but at least something like "my-project-id" and "my-interconnect-id" are probably fine.

resource "google_compute_interconnect_attachment" "default" {
name = "test-interconnect"
interconnect = "https://googleapis.com/compute/v1/projects/.../global/interconnects/..."
router = "https://googleapis.com/compute/v1/projects/.../regions/.../routers/..."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These both should support the name or the self link



* `cloud_router_ip_address` -
[Output Only] IPv4 address + prefix length to be configured on Cloud Router
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the [Output Only]s?

@nat-henderson nat-henderson merged commit 06c2f84 into hashicorp:master Sep 21, 2018
@nmelepat
Copy link

I have tested this recently and it can create the VLAN attachment properly. But whats missing is the BGP session setup on the VLAN attachment. Also, the VLAN ID is picked quite differently than when you do from the UI.

Operational_status = OS_UNPROVISIONED
private_interconnect_info.# = 1
private_interconnect_info.0.tag8021q = 1100

@nat-henderson
Copy link
Contributor

I'm sorry - I don't understand the issue. Could you post debug logs? This resource is not something we can test on our end, since we don't have an interconnect available - we'll have to work with you to try and solve the problem.

@netturpin
Copy link

Before doing the setup of the bgp session, a router-interface needs to be associated with a vlan-attachment. (I've just created issue #2116 for that topic).

chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
@ghost
Copy link

ghost commented Nov 16, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants