Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_container_cluster regional clusters are GA and not beta anymore #2286

Closed
idsvandermolen opened this issue Oct 19, 2018 · 5 comments
Closed
Assignees
Labels
bug forward/review In review; remove label to forward service/container

Comments

@idsvandermolen
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
  • If an issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to "hashibot", a community member has claimed the issue already.

Terraform Version

Terraform v0.11.8

  • provider.google v1.19.1

Affected Resource(s)

  • google_container_cluster

Terraform Configuration Files

provider "google" {}

resource "google_container_cluster" "primary" {
  name   = "primary"
  region = "europe-west4"
}

Debug Output

Panic Output

Expected Behavior

terraform validate should not complain

Actual Behavior

terraform validate complains about region being a beta / deprecated:

Warning: google_container_cluster.primary: "region": [DEPRECATED] This field is in beta and will be removed from this provider. Use it in the the google-beta provider instead. See https://terraform.io/docs/providers/google/provider_versions.html for more details.

Steps to Reproduce

  1. create file with terraform config
  2. terraform init
  3. terraform validate

Important Factoids

Terraform docs
https://www.terraform.io/docs/providers/google/r/container_cluster.html#region also mark region as beta, however Regional Clusters have been GA since June: https://cloud.google.com/blog/products/gcp/regional-clusters-in-google-kubernetes-engine-are-now-generally-available

References

@ghost ghost added the bug label Oct 19, 2018
@emilymye
Copy link
Contributor

@danawillow is it safe to just rip out the deprecation warning here?

@danawillow
Copy link
Contributor

Neat! Probably yes, but I'd check the PR that added the deprecation warning just to make sure it didn't do anything else.

@danawillow danawillow self-assigned this Oct 30, 2018
danawillow pushed a commit that referenced this issue Oct 31, 2018
<!-- This change is generated by MagicModules. -->
/cc @danawillow 

Fixes #2286
nat-henderson pushed a commit that referenced this issue Dec 4, 2018
<!-- This change is generated by MagicModules. -->
/cc @danawillow

Fixes #2286
nat-henderson pushed a commit that referenced this issue Dec 5, 2018
<!-- This change is generated by MagicModules. -->
/cc @danawillow

Fixes #2286
nat-henderson pushed a commit that referenced this issue Dec 6, 2018
<!-- This change is generated by MagicModules. -->
/cc @danawillow

Fixes #2286
nat-henderson pushed a commit that referenced this issue Dec 13, 2018
<!-- This change is generated by MagicModules. -->
/cc @danawillow

Fixes #2286
nat-henderson pushed a commit that referenced this issue Dec 21, 2018
<!-- This change is generated by MagicModules. -->
/cc @danawillow 

Fixes #2286
nat-henderson pushed a commit that referenced this issue Dec 21, 2018
<!-- This change is generated by MagicModules. -->
/cc @danawillow 

Fixes #2286
@slavaaaaaaaaaa
Copy link

The docs still specify region as a beta attribute.

google_container_node_pool is also affected by the same issue, is that intended?

@nat-henderson
Copy link
Contributor

It's on master, but I don't think it's present in any of our releases yet. Github doesn't seem to think so. That would explain the docs situation.

@ghost
Copy link

ghost commented Jan 30, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 30, 2019
@github-actions github-actions bot added service/container forward/review In review; remove label to forward labels Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug forward/review In review; remove label to forward service/container
Projects
None yet
Development

No branches or pull requests

5 participants