feat(spanner): added support for setting database_dialect on google_spanner_database
#11235
Conversation
rahul2393
changed the title
google_spanner_databasegoogle_spanner_database
rahul2393
force-pushed
the
spanner-database-dialect
branch
from
9cf50bf
to
9e39ca3
Compare
…spanner_database`
rahul2393
force-pushed
the
spanner-database-dialect
branch
from
9e39ca3
to
4783be7
Compare
| if v == nil { | ||
| return v | ||
| } | ||
| return ConvertSelfLinkToV1(v.(string)) |
There was a problem hiding this comment.
ConvertSelfLinkToV1() cleans URLs. But database dialects are enums, I didn't think they can contain URLs? So that function should be a no-op for any valid dialect. Should this be a no-op like (for example) flattenSpannerDatabaseState() above?
| @@ -100,6 +100,10 @@ The following arguments are supported: | |||
| * `deletion_protection` - (Optional) Whether or not to allow Terraform to destroy the instance. Unless this field is set to false | |||
| in Terraform state, a `terraform destroy` or `terraform apply` that would delete the instance will fail. | |||
|
|
|||
| * `database_dialect` - (Optional) The dialect of the Cloud Spanner Database. | |||
| If it is not provided, "DATABASE_DIALECT_UNSPECIFIED" will be used. | |||
There was a problem hiding this comment.
Could I request adding an extra bit of information to this comment?
If it is not provided, "DATABASE_DIALECT_UNSPECIFIED" will be used, which will create a Google Standard SQL database.
|
Patch will be auto-generated by GoogleCloudPlatform/magic-modules#5799 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Add support for setting database_dialect on google_spanner_database