Restrict the number of health_checks in Backend Service resources to exactly 1. #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stack72
reviewed
Jun 21, 2017
There was a problem hiding this comment.
Hi @rileykarson
This LGTM - could of minor nits in there that you may want to change later :)
| Set: schema.HashString, | ||
| Required: true, | ||
| MinItems: 1, |
There was a problem hiding this comment.
If you have a required: true then you won't need MinItems: 1 :)
| Set: schema.HashString, | ||
| Required: true, | ||
| MinItems: 1, |
pdecat
pushed a commit
to pdecat/terraform-provider-google
that referenced
this pull request
Jun 29, 2017
…ount Restrict the number of health_checks in Backend Service resources to exactly 1.
luis-silva
pushed a commit
to luis-silva/terraform-provider-google
that referenced
this pull request
May 21, 2019
Support cloud sql private ip (incorporating previous PR feedback)
luis-silva
pushed a commit
to luis-silva/terraform-provider-google
that referenced
this pull request
May 21, 2019
Support cloud sql private ip (incorporating previous PR feedback)
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #144.
Affects
google_compute_backend_serviceandgoogle_compute_region_backend_service.