Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked service labeler to act in more cases #17794

Merged
merged 7 commits into from
Apr 8, 2024
Merged

Conversation

melinath
Copy link
Collaborator

@melinath melinath commented Apr 8, 2024

Specifically, if labels are removed or if the first comment is edited - but only if there is not a service label yet.

New or Affected Resource(s)

google_alloydb_instance

Specifically, if labels are removed or if the first comment is edited - but only if there is not a service label yet.
Copy link

github-actions bot commented Apr 8, 2024

** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you!

@melinath
Copy link
Collaborator Author

melinath commented Apr 8, 2024

I'm not entirely sure whether this will work as desired... I'll need to double-check after merge.

@melinath
Copy link
Collaborator Author

melinath commented Apr 8, 2024

@melinath
Copy link
Collaborator Author

melinath commented Apr 8, 2024

Successfully computed new service labels: https://github.com/hashicorp/terraform-provider-google/actions/runs/8606515668/job/23585111965?pr=17794#step:5:16 - wasn't able to update because PRs only get read permissions.

@melinath melinath merged commit 4f7c4fe into main Apr 8, 2024
2 checks passed
@melinath melinath deleted the service-labels-on-update branch April 8, 2024 21:08
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants