Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitespace diffs on logging_sink exclusion filters #19744

Conversation

modular-magician
Copy link
Collaborator

The top-level filter resource already has OptionalSurroundingSpacesSuppress, but the filter on exclusions does not causing unnecessary diffs when there only difference is leading/trailing whitespace, common because of the use of HEREDOC on this attribute.

logging: fixed the whitespace permadiff on `exclusions.filter` field in `google_logging_billing_account_sink`, `google_logging_folder_sink`, `google_logging_organization_sink` and `google_logging_project_sink` resources

Derived from GoogleCloudPlatform/magic-modules#11900

[upstream:ee7110881c0f14649c942dc629dd57ee859acbf1]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 1080042 into hashicorp:main Oct 3, 2024
4 checks passed
Copy link

github-actions bot commented Nov 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
@modular-magician modular-magician deleted the downstream-pr-ee7110881c0f14649c942dc629dd57ee859acbf1 branch November 17, 2024 01:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant