Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container: fix in-place updates for node_config.containerd_config #20112

Conversation

modular-magician
Copy link
Collaborator

It appears that in-place updates were never implemented for node_config.containerd_config, when contained within either google_container_cluster or google_container_node_pool

Fixes #19056
Related to #19225 (already closed / fixed)

The actual implementation is pretty simple, and is basically copy / paste from other fields.

The adjustments to existing tests are a little trickier to parse out.

Basically, the existing tests for both google_container_cluster and google_container_node_pool mostly covered node_config_defaults (maybe because that's the only one updates worked for), and didn't cover updates in node_config. In at least one case, the same test was used for all of node_config_defaults, node_pool.node_config, and node_config, and I've mostly preserved that, just adjusting the order. Note that in at least one case, that will likely require recreating the entire cluster and / or its node-pools; I've moved that test (named node_pool {} block in google_container_cluster) to be the last test, and attempted to add some comments.

Another approach would be to split out the tests of node_config_defaults, node_pool.node_config, and node_config.

Release Note Template for Downstream PRs (will be copied)

container: fixed in-place updates for `node_config.containerd_config` in `google_container_cluster` and `google_container_node_pool`

Derived from GoogleCloudPlatform/magic-modules#12135

…ashicorp#12135)

Signed-off-by: William Yardley <wyardley@users.noreply.github.com>

[upstream:07118df4325b99355b62c9acdaeb95102dd935a2]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit aa28027 into hashicorp:main Oct 30, 2024
1 check passed
@modular-magician modular-magician deleted the downstream-pr-07118df4325b99355b62c9acdaeb95102dd935a2 branch November 17, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

containerd_config in resource google_container_cluster is not working
1 participant