Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diff suppress function ignoring additive_vpc_scope_dns_domain in Autopilot clusters #20937

Conversation

modular-magician
Copy link
Collaborator

self-appointed successor to #11744

GKE Autopilot allows setting additive VPC scope domain on creation only. However, current implementation of the diff suppress function for Autopilot clusters removes any values in dns_config of Autopilot clusters, all the time.

This change permits setting additive VPC scope domain.

Remaining action items:

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: fixed `additive_vpc_scope_dns_domain` being ignored in Autopilot cluster definition

Derived from GoogleCloudPlatform/magic-modules#12567

…Autopilot clusters (hashicorp#12567)

[upstream:a575eb9063ffc392d921a375709bf6e829698420]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner January 16, 2025 21:35
@modular-magician modular-magician merged commit 1695c11 into hashicorp:main Jan 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant