Initial addition of generated Image to Terraform. #2769
Conversation
modular-magician
force-pushed
the
codegen-pr-1121
branch
from
5e5c832 to
2207c9b
Compare
google/resource_compute_image.go
Outdated
| }, | ||
| "sha1": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| ForceNew: true, | ||
| }, | ||
| "container_type": { | ||
| "source": { | ||
| Type: schema.TypeString, | ||
| Optional: true, |
There was a problem hiding this comment.
I think this should stay as required
| func testAccComputeImage_imageBasicExample(val string) string { | ||
| return fmt.Sprintf(` | ||
| resource "google_compute_image" "example" { | ||
| name = "" |
There was a problem hiding this comment.
This should probably be a value
| name = "" | ||
|
|
||
| raw_disk { | ||
| source = "https://storage.googleapis.com/my-bucket/my-disk-image-tarball.tar.gz" |
There was a problem hiding this comment.
Does this test pass? I assume this bucket is fake
There was a problem hiding this comment.
Ah right, I forgot about the examples creating tests. Grabbed the tgz from the existing tests, working its way through now.
| * `labels` - (Optional) A set of key/value label pairs to assign to the image. | ||
| * `labels` - | ||
| (Optional) | ||
| Labels to apply to this Snapshot. |
modular-magician
force-pushed
the
codegen-pr-1121
branch
from
2207c9b to
dc7b6ab
Compare
modular-magician
force-pushed
the
codegen-pr-1121
branch
from
dc7b6ab to
8d62f27
Compare
modular-magician
force-pushed
the
codegen-pr-1121
branch
from
8d62f27 to
8122e1d
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
/cc @ndmckinley