Correct documentation about multiple ssl certificate usage #4316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resource `google_compute_target_https_proxy` attribute `ssl_certificates` is wrongly repoted in the doc as supporting only 1 certificate but goggle cloud supporte ;ultiple and in fact the code accept ;ultiple and it's working.
danawillow
approved these changes
Dec 5, 2019
There was a problem hiding this comment.
Thanks @tblaisot, and sorry for the delay in getting this reviewed! Since this is in a file generated by https://github.com/GoogleCloudPlatform/magic-modules, I'll take care of getting it upstreamed properly.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resource
google_compute_target_https_proxyattributessl_certificatesis wrongly repoted in the doc as supporting only 1 certificate but goggle cloud supporte ;ultiple and in fact the code accept ;ultiple and it's working.