Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in project retries, add billinginfo retries #5614

Conversation

modular-magician
Copy link
Collaborator

Upstreams #5578

This change affects two areas:

  1. When the result of a Projects.Update(...) request is an error, the returned
    'project' value is 'nil'. Previously, this value was stored in 'p' which
    was then dereferenced when retrieving 'p.ProjectId' on the subsequent retry.
    This fix only allows 'p' to be overwritten if the Projects.Update(...)
    request is successful.
  2. Requests to the BillingInfo service could fail due to transient HTTP timeouts
    (usually TLS handshake negotiation timeout) and for throttling (HTTP
    429). Adding retries addresses this.

Release Note Template for Downstream PRs (will be copied)

resourcemanager: fixed retry behavior for updates in `google_project`, added retries for billing metadata requests

Derived from GoogleCloudPlatform/magic-modules#3091

This change affects two areas::
1. When the result of a Projects.Update(...) request is an error, the returned
    'project' value is 'nil'. Previously, this value was stored in 'p' which
    was then dereferenced when retrieving 'p.ProjectId' on the subsequent retry.
    This fix only allows 'p' to be overwritten if the Projects.Update(...)
    request is successful.
2. Requests to the BillingInfo service could fail due to transient HTTP timeouts
   (usually TLS handshake negotiation timeout) and for throttling (HTTP
   429). Adding retries addresses this.

Co-authored-by: Rob Leidle <rleidle@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/s label Feb 7, 2020
@modular-magician modular-magician merged commit ac89194 into hashicorp:master Feb 7, 2020
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
@modular-magician modular-magician deleted the downstream-pr-3ba90745f737a9995cfa7887aed9895622a8de4d branch November 17, 2024 00:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants