Make google_iam_policy page NOTE more prominent
#5638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the API the terraform provider uses (at the time of this writing), defining and applying a google_iam_policy resource will overwrite any existing policies for the given project. It may be reasonable to assume that this resource could be additive, so moving the `NOTE` higher on the page can help reduce issues caused by these bad assumptions.
ghost
requested a review
from 
nat-henderson
approved these changes
Feb 10, 2020
nat-henderson
added a commit
to nat-henderson/magic-modules
that referenced
this pull request
Feb 10, 2020
modular-magician
pushed a commit
to modular-magician/terraform-provider-google
that referenced
this pull request
Feb 10, 2020
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
pushed a commit
to modular-magician/terraform-provider-google-beta
that referenced
this pull request
Feb 10, 2020
Signed-off-by: Modular Magician <magic-modules@google.com>
nat-henderson
added a commit
to nat-henderson/magic-modules
that referenced
this pull request
Feb 10, 2020
modular-magician
pushed a commit
to modular-magician/terraform-provider-google
that referenced
this pull request
Feb 10, 2020
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
pushed a commit
to modular-magician/terraform-provider-google-beta
that referenced
this pull request
Feb 10, 2020
Signed-off-by: Modular Magician <magic-modules@google.com>
nat-henderson
added a commit
to GoogleCloudPlatform/magic-modules
that referenced
this pull request
Feb 10, 2020
* Upstream hashicorp/terraform-provider-google#5638. * Do linting after diff.
modular-magician
added a commit
to modular-magician/terraform-provider-google
that referenced
this pull request
Feb 10, 2020
* Upstream hashicorp#5638. * Do linting after diff. Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
added a commit
to modular-magician/terraform-provider-google-beta
that referenced
this pull request
Feb 10, 2020
* Upstream hashicorp/terraform-provider-google#5638. * Do linting after diff. Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
added a commit
to hashicorp/terraform-provider-google-beta
that referenced
this pull request
Feb 10, 2020
* Upstream hashicorp/terraform-provider-google#5638. * Do linting after diff. Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the API the terraform provider uses (at the time of this
writing), defining and applying a google_iam_policy resource will
overwrite any existing policies for the given project. It may be
reasonable to assume that this resource could be additive, so moving
the
NOTEhigher on the page can help reduce issues caused by thesebad assumptions.
Related beta provider PR: hashicorp/terraform-provider-google-beta#1744