-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.54.0 - release notes and cherry pick #8258
3.54.0 - release notes and cherry pick #8258
Conversation
…#8256) Signed-off-by: Modular Magician <magic-modules@google.com>
hi @rileykarson, I'm going to be out of town for the remainder of the week but just wanted to make sure I got this out there. Could you shepherd this cherrypick and audit these notes before the release Monday? There was a failing test on a newly added resource TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityCmekExample in tpgb. Could you take a look at it? I think we should be good to go. Since it's a new resource any flaws won't break existing users. |
hi, |
We treated this as a compatible change, eg one that we can release in a minor release. The change should cause Terraform to attempt to recreate the resource in cases where the API would have returned an error indicating that changing from one schema to another was impossible. However the interaction with some other behaviour(s) on the field caused a larger impact than expected, and we'll revert for the next release. See #8282 We plan to reintroduce the change during the |
hello @rileykarson, I've wrote feedback in #1144 (comment), but I see issue is closed, so pinging here :) thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
contains the release notes and cherry-pick of c216b91568068600a59b99c375d42f9400d2e943