Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.54.0 - release notes and cherry pick #8258

Merged
merged 7 commits into from
Jan 22, 2021

Conversation

ScottSuarez
Copy link
Collaborator

@ScottSuarez ScottSuarez commented Jan 20, 2021

contains the release notes and cherry-pick of c216b91568068600a59b99c375d42f9400d2e943

@ghost ghost added the size/xs label Jan 20, 2021
…#8256)

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added size/s and removed size/xs labels Jan 21, 2021
@ScottSuarez ScottSuarez marked this pull request as ready for review January 21, 2021 01:15
@ScottSuarez ScottSuarez changed the title 3.54.0 - release notes draft 3.54.0 - release notes and cherry pick Jan 21, 2021
@ScottSuarez
Copy link
Collaborator Author

hi @rileykarson, I'm going to be out of town for the remainder of the week but just wanted to make sure I got this out there. Could you shepherd this cherrypick and audit these notes before the release Monday?

There was a failing test on a newly added resource TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityCmekExample in tpgb. Could you take a look at it? I think we should be good to go. Since it's a new resource any flaws won't break existing users.

@rileykarson rileykarson changed the base branch from master to release-3.54.0 January 21, 2021 18:34
@rileykarson rileykarson merged commit 0e9b232 into hashicorp:release-3.54.0 Jan 22, 2021
@m1n0
Copy link

m1n0 commented Jan 27, 2021

hi, bigquery: made incompatible changes to the `google_bigquery_table.schema` field to cause the resource to be recreated seems like a quite disruptive change for a small version bump. I see that 54 was unreleased but I could not find any info on that, what happened here please?

@rileykarson
Copy link
Collaborator

We treated this as a compatible change, eg one that we can release in a minor release. The change should cause Terraform to attempt to recreate the resource in cases where the API would have returned an error indicating that changing from one schema to another was impossible. However the interaction with some other behaviour(s) on the field caused a larger impact than expected, and we'll revert for the next release. See #8282

We plan to reintroduce the change during the 3.X release series at this time, although feedback is appreciated. #1144 is a good place for it, I think.

@maroshmka
Copy link

hello @rileykarson, I've wrote feedback in #1144 (comment), but I see issue is closed, so pinging here :) thanks!

@ghost
Copy link

ghost commented Feb 22, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants