CI: set TF_ACC_TERRAFORM_VERSION
in workflow instead of repo variable
#1430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
configuration variables have a limited scope, preventing them from being used in pull requests. This causes the
Deferred Actions
workflow to fail since${{ vars.TERRAFORM_VERSION_EXP }}
doesn't return the version but instead just an empty string. This is a known issue across github: https://github.com/orgs/community/discussions/44322This is seen in a recent review of a PR: https://github.com/hashicorp/terraform-provider-helm/actions/runs/9781860920/job/27387198282?pr=1247
Solution is to explicitly set it in the workflow rather than rely on a repo variable.
The same fix can be found in the kubernetes provider as well: hashicorp/terraform-provider-kubernetes#2550
Acceptance tests
Release Note
Release note for CHANGELOG:
References
Community Note