Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix missed postrender binary path arguments parsing #1534

Merged
merged 4 commits into from
Nov 14, 2024
Merged

🐛 Fix missed postrender binary path arguments parsing #1534

merged 4 commits into from
Nov 14, 2024
+40 −5

Conversation

arybolovlev
Copy link
Contributor

@arybolovlev arybolovlev commented Nov 14, 2024 •
edited
Loading

Description

This is a quick fix to the issue where the postrender.args attribute is not parsed during creation. It was accidentally removed in this PR.

References

Fix: #1533

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@arybolovlev arybolovlev changed the title 🐛 Fix missed binary path arguments parsing 🐛 Fix missed postrender binary path arguments parsing Nov 14, 2024
@arybolovlev arybolovlev marked this pull request as ready for review November 14, 2024 09:56
@arybolovlev arybolovlev requested a review from a team as a code owner November 14, 2024 09:56
@github-actions github-actions bot added size/S and removed size/XS labels Nov 14, 2024
dawid-remitly
dawid-remitly reviewed Nov 14, 2024
View reviewed changes
.changelog/1534.txt Outdated
@@ -0,0 +1,3 @@
```release-note:bug
`resourehelm_release`: fix an issue where `postrender.args` is not parsed correctly.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably typo resource.helm_release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Thanks for noticing this. :-)

alexsomesan
alexsomesan approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable 👍

@arybolovlev arybolovlev merged commit 1156a26 into main Nov 14, 2024
19 checks passed
@arybolovlev arybolovlev deleted the fix-binary-path-args branch November 14, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawid-remitly dawid-remitly dawid-remitly left review comments

@alexsomesan alexsomesan alexsomesan approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

postrender ignores args since v2.15.0
3 participants
@arybolovlev @alexsomesan @dawid-remitly