Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow application/x-pem-file content type #147

Closed
wants to merge 1 commit into from

Conversation

erpel
Copy link

@erpel erpel commented Jun 22, 2022

This refers to PEM encoded files often used for certificates and related
data.

Example source for this content type: ietf-wg-acme/acme#120

This refers to PEM encoded files often used for certificates and related
data.
@erpel erpel requested a review from a team as a code owner June 22, 2022 10:28
@hashicorp-cla
Copy link

hashicorp-cla commented Jun 22, 2022

CLA assistant check
All committers have signed the CLA.

@lucymhdavies
Copy link

On a related note, recognising application/pem-certificate-chain would be useful.
Perhaps, rather than hard-coding specific content types we expect, we should add a parameter that would allow the user to specify what content type they are expecting.

In my case:

data "http" "ca" {
  url = "https://vault.fancycorp.io/v1/pki/root/ca/pem"
  expected_content_types = [
    "application/pem-certificate-chain"
  ]
}

@erpel's use-case would likely be similar.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants