feat: support provider-level host configuration #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdb
force-pushed
the
mdb/configurable-host
branch
from
0175420 to
acad059
Compare
mdb
commented
Apr 21, 2025
| request.Host = header | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Callout: ☝️ Ideally (at least for my use case), these provider-level headers are regarded as sensitive and therefore not logged in plain text if/when TF_DEBUG=1, etc. I haven't dug too deep on whether they currently are.
mdb
force-pushed
the
mdb/configurable-host
branch
from
acad059 to
7cba77c
Compare
mdb
force-pushed
the
mdb/configurable-host
branch
from
7cba77c to
1c2ec85
Compare
mdb
changed the title
mdb
force-pushed
the
mdb/configurable-host
branch
2 times, most recently
from
db7d1a5 to
75aa6e5
Compare
This seeks to address issue hashicorp#34 by offering the ability to specify provider-level host configuration & host-specific request headers. Signed-off-by: Mike Ball <mikedball@gmail.com>
mdb
force-pushed
the
mdb/configurable-host
branch
from
75aa6e5 to
b217007
Compare
|
Hi @mdb, Thanks for your PR and for your patience! I'm sorry if my previous reply came across as too optimistic. We appreciate your contribution and hope you understand our decision. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seeks to address issue #34 by offering the ability to specify provider-level host configuration & host-specific request headers.
This also presents as an alternative implementation to PR #521 and PR #12, perhaps a bit more inline with what @apparentlymart recommended a while back.