Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

chore: install to terraforms plugin directory #64

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

endocrimes
Copy link
Contributor

👋 folks,
I was trying out the alpha provider and ran into issues due to the CI failures causing nightlies to not be up to date. I somewhat expected make install to install the provider into a usable place, and was surprised when it didn't.

Filling this to simplify the testing and installation workflow for others, but understand if you don't want to merge this and would rather folks build/copy manually.

This change causes `make install` to install the provider into the terraform
plugin directory for the current platform.

This simplifies making changes to the provider and also installing
pre-release versions of the provider ahead of an up to date nightly
release.
Copy link
Contributor

@aareet aareet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a nice addition of convenience

@aareet aareet requested a review from dak1n1 June 15, 2020 16:25
@dak1n1
Copy link
Contributor

dak1n1 commented Jun 15, 2020

Tested on linux. This is a great change, thanks!

@dak1n1 dak1n1 merged commit e2f3e05 into hashicorp:master Jun 15, 2020
aareet added a commit that referenced this pull request Jun 16, 2020
As a follow-up to #64, update the docs to reflect new build process.
@aareet aareet mentioned this pull request Jun 16, 2020
@endocrimes endocrimes deleted the dani/simplify-install branch June 16, 2020 11:45
aareet added a commit that referenced this pull request Jun 20, 2020
As a follow-up to #64, update the docs to reflect new build process.
@ghost
Copy link

ghost commented Jul 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants