Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade k8s client libs to 1.10 #162

Merged
merged 3 commits into from
Oct 4, 2018
Merged

Upgrade k8s client libs to 1.10 #162

merged 3 commits into from
Oct 4, 2018

Conversation

cosmopetrich
Copy link

This is based on the work of @nickschuch and @pdecat in #117. Access to a newer Kube client will help unblock several open PRs that add useful features (ClusterRoleBinging, Deployments, NetworkPolicies) and I thought it might be easier to open a new PR against Kube 1.10 and a newer master than to just ping the existing PR. I'm happy to close this if we'd rather proceed with the original PR.

The steps used to create this are almost identical to those used for the 1.9 PR. I also had to update github.com/Azure/go-autorest.

The tests and basic acceptance tests pass. I believe that the acceptance test failure in the 1.9 PR was fixed by #122.

nickschuch and others added 3 commits May 7, 2018 13:01
@evilmarty
Copy link

To help expedite this it's probably a good idea to post test results.

@christopherhein
Copy link

Anything that is needed to help move this along, would be nice to see EKS support for the Kubernetes TF provider :)

@whyman
Copy link

whyman commented Aug 6, 2018

Offering my help to get this merged also? Are we waiting on something specific?

@cosmopetrich
Copy link
Author

@christopherhein @v00d00 My impression is that this provider is unmaintained at the moment. I'm not sure if there is a way to move the open PRs along until a maintainer is found (see #178).

Until then it might be worth taking a look at the actively-maintained fork https://github.com/sl1pm4t/terraform-provider-kubernetes which includes some additional features such as RBAC and Deployments.

@christopherhein
Copy link

Thank you @cosmopetrich ! Very helpful!

@Jeeppler
Copy link

I am unable to use this provider without support for v1.10. This the only version supported by EKS.

@alexsomesan
Copy link
Member

I've retested this change and it works as expected on top of current master.
I think it's safe to merge.

@alexsomesan alexsomesan merged commit 523ef33 into hashicorp:master Oct 4, 2018
@Jeeppler
Copy link

Jeeppler commented Oct 5, 2018

@alexsomesan will you publish a new release of the provider based on this change?

@alexsomesan
Copy link
Member

@Jeeppler I'm thinking this change alone doesn't bring a whole lot of value to users - it mostly helps developers. Is this blocking you in any way?
I'd like to wait for #73 to get merged and then release.

@Jeeppler
Copy link

Jeeppler commented Oct 5, 2018

@alexsomesan Yes, I work with EKS which uses Kubernetes 1.10, basically I cant use the Kubernetes provider unless I can use it with Kubernetes 1.10.

@alexsomesan
Copy link
Member

@Jeeppler As far as I could test, it seems the current release of the provider can talk to an EKS cluster just fine. Would you be so kind to provide me with more details of how exactly is it blocking you?

This particular change won't actually give you access to any new 1.10 features unless the specific resources are added or updated explicitly in the K8S provider.

@coryflucas
Copy link
Contributor

@alexsomesan I believe this change should allow using a kube config with the aws-iam-authenticator which is used via an ExecCredentials resource in the config. See: https://kubernetes.io/docs/reference/access-authn-authz/authentication/#client-go-credential-plugins.

@coryflucas
Copy link
Contributor

Also see #161.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants