-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade k8s client libs to 1.10 #162
Conversation
…o use k8s/client-go 1.9.0 Based on nickschuch/terraform-provider-kubernetes@aaff7e9.
… of k8s libs to 1.9
To help expedite this it's probably a good idea to post test results. |
Anything that is needed to help move this along, would be nice to see EKS support for the Kubernetes TF provider :) |
Offering my help to get this merged also? Are we waiting on something specific? |
@christopherhein @v00d00 My impression is that this provider is unmaintained at the moment. I'm not sure if there is a way to move the open PRs along until a maintainer is found (see #178). Until then it might be worth taking a look at the actively-maintained fork https://github.com/sl1pm4t/terraform-provider-kubernetes which includes some additional features such as RBAC and Deployments. |
Thank you @cosmopetrich ! Very helpful! |
I am unable to use this provider without support for v1.10. This the only version supported by EKS. |
I've retested this change and it works as expected on top of current master. |
@alexsomesan will you publish a new release of the provider based on this change? |
@alexsomesan Yes, I work with EKS which uses Kubernetes 1.10, basically I cant use the Kubernetes provider unless I can use it with Kubernetes 1.10. |
@Jeeppler As far as I could test, it seems the current release of the provider can talk to an EKS cluster just fine. Would you be so kind to provide me with more details of how exactly is it blocking you? This particular change won't actually give you access to any new 1.10 features unless the specific resources are added or updated explicitly in the K8S provider. |
@alexsomesan I believe this change should allow using a kube config with the aws-iam-authenticator which is used via an ExecCredentials resource in the config. See: https://kubernetes.io/docs/reference/access-authn-authz/authentication/#client-go-credential-plugins. |
Also see #161. |
This is based on the work of @nickschuch and @pdecat in #117. Access to a newer Kube client will help unblock several open PRs that add useful features (ClusterRoleBinging, Deployments, NetworkPolicies) and I thought it might be easier to open a new PR against Kube 1.10 and a newer
master
than to just ping the existing PR. I'm happy to close this if we'd rather proceed with the original PR.The steps used to create this are almost identical to those used for the 1.9 PR. I also had to update github.com/Azure/go-autorest.
The tests and basic acceptance tests pass. I believe that the acceptance test failure in the 1.9 PR was fixed by #122.