Fix error in docs, required field was marked optional #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arybolovlev
approved these changes
Aug 16, 2023
dduportal
referenced
this pull request
in jenkins-infra/azure
Sep 23, 2023
<Actions>
<action
id="60b545e3a7c08156b6118e64d9cdf055bc66d491f519bb73d2490ee2958a6c05">
<h3>Bump Terraform `kubernetes` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
<summary>Update Terraform lock file</summary>
<p>"hashicorp/kubernetes" updated from "2.23.0" to
"2.23.0" in file ".terraform.lock.hcl"</p>
<details>
<summary>2.23.0</summary>
<pre>Changelog retrieved
from:
	https://github.com/hashicorp/terraform-provider-kubernetes/releases/tag/v2.23.0
FEATURES:

*
`resource/kubernetes_cron_job_v1`: add a new volume type `ephemeral` to
`spec.job_template.spec.template.spec.volume` to support generic
ephemeral volumes.
[[GH-2199](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2199)]
*
`resource/kubernetes_cron_job`: add a new volume type `ephemeral` to
`spec.job_template.spec.template.spec.volume` to support generic
ephemeral volumes.
[[GH-2199](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2199)]
*
`resource/kubernetes_daemon_set_v1`: add a new volume type `ephemeral`
to `spec.template.spec.volume` to support generic ephemeral volumes.
[[GH-2199](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2199)]
*
`resource/kubernetes_daemonset`: add a new volume type `ephemeral` to
`spec.template.spec..volume` to support generic ephemeral volumes.
[[GH-2199](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2199)]
*
`resource/kubernetes_deployment_v1`: add a new volume type `ephemeral`
to `spec.template.spec.volume` to support generic ephemeral volumes.
[[GH-2199](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2199)]
*
`resource/kubernetes_deployment`: add a new volume type `ephemeral` to
`spec.template.spec.volume` to support generic ephemeral volumes.
[[GH-2199](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2199)]
*
`resource/kubernetes_job_v1`: add a new volume type `ephemeral` to
`spec.template.spec.volume` to support generic ephemeral volumes.
[[GH-2199](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2199)]
*
`resource/kubernetes_job`: add a new volume type `ephemeral` to
`spec.template.spec.volume` to support generic ephemeral volumes.
[[GH-2199](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2199)]
*
`resource/kubernetes_pod_v1`: add a new volume type `ephemeral` to
`spec.volume` to support generic ephemeral volumes.
[[GH-2199](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2199)]
*
`resource/kubernetes_pod`: add a new volume type `ephemeral` to
`spec.volume` to support generic ephemeral volumes.
[[GH-2199](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2199)]

ENHANCEMENTS:

*
`resource/kubernetes_endpoint_slice_v1`: make attribute
`endpoint.condition` optional. If you had previously included an empty
block `condition {}` in your configuration, we request you to remove it.
Doing so will prevent receiving continuous _"update in-place"_
messages while performing the plan and apply operations.
[[GH-2208](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2208)]
*
`resource/kubernetes_pod_v1`: add a new attribute `target_state` to
specify the Pod phase(s) that indicate whether it was successfully
created.
[[GH-2200](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2200)]
*
`resource/kubernetes_pod`: add a new attribute `target_state` to specify
the Pod phase(s) that indicate whether it was successfully created.
[[GH-2200](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2200)]

BUG
FIXES:

* `resource/kubernetes_manifest`: update flow in `wait`
block to fix timeout bug within tf apply where the resource is created
and appears in Kubernetes but does not appear in TF state file after
deadline. The fix would ensure that the resource has been created in the
state file while also tainting the resource requiring the user to make
the necessary changes in order for their to not be another timeout
error.
[[GH-2163](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2163)]

DOCS:

*
Fix external broken links in the documentation.
[[GH-2221](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2221)]

##
Community Contributors 🙌

- @JHeilCoveo made their
contribution in
hashicorp/terraform-provider-kubernetes#2183
@baumandm made their contribution in
hashicorp/terraform-provider-kubernetes#1026
@vastep made their contribution in
hashicorp/terraform-provider-kubernetes#2193
@rafed made their contribution in
hashicorp/terraform-provider-kubernetes#2214,
https://github.com/hashicorp/terraform-provider-kubernetes/pull/2225


</pre>
</details>
</details>
</action>
</Actions>
---
<table>
<tr>
<td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
</td>
<td>
<p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
</p>
<details><summary>Options:</summary>
<br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
<ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
</ul>
<p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
</p>
</details>
</td>
</tr>
</table>
Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without providing the name argument an error is thrown. So I'm assuming the name fields should be
requiredinstead ofoptionalin the docs.Acceptance tests
Release Note
Release note for CHANGELOG:
Community Note