Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes_server_version data source #2306

Merged
merged 9 commits into from
Aug 9, 2024
Merged

Conversation

daemon4d-us
Copy link
Contributor

Description

Acceptance tests

  • [ Yes] Have you added an acceptance test for the functionality being added?
  • [ Yes] Have you run the acceptance tests on this branch?

Output from acceptance testing:

dsidorenko@dsidorenko01-la terraform-provider-kubernetes % make testacc TESTARGS='-run=TestAccKubernetesDataSourceServerVersion_basic'
==> Checking that code complies with gofmt requirements...
go vet .
TF_ACC=1 go test "/Users/dsidorenko/go/src/github.com/hashicorp/terraform-provider-kubernetes/kubernetes" -v -vet=off -run=TestAccKubernetesDataSourceServerVersion_basic -parallel 8 -timeout 3h
=== RUN   TestAccKubernetesDataSourceServerVersion_basic
=== PAUSE TestAccKubernetesDataSourceServerVersion_basic
=== CONT  TestAccKubernetesDataSourceServerVersion_basic
--- PASS: TestAccKubernetesDataSourceServerVersion_basic (3.64s)
PASS
ok      github.com/hashicorp/terraform-provider-kubernetes/kubernetes   4.069s

Release Note

Release note for CHANGELOG:

data kubernetes_server_version added. 
...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@daemon4d-us daemon4d-us requested a review from a team as a code owner October 5, 2023 06:54
@hashicorp-cla
Copy link

hashicorp-cla commented Oct 5, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added size/L and removed size/M labels Oct 5, 2023
@daemon4d-us
Copy link
Contributor Author

Hi @torqu3e Does this look better?

@alexsomesan
Copy link
Member

@daemon4d-us
Changes generally look good and this is a useful feature to have in the provider.
In order for community PRs to be merged contributors need to agree to the CLA. Please see the prompt above from hashicorp-cla bot.

@daemon4d-us
Copy link
Contributor Author

Hm, something is not working quite good here for me. I have actually signed the CLA, but still appears in Pending state here.

@arybolovlev
Copy link
Contributor

Hm, something is not working quite good here for me. I have actually signed the CLA, but still appears in Pending state here.

As far as I can see, 2 out of 3 commits including the initial one were made by a user @dsidorenkonx and you have opened this PR from the username @daemon4d-us. That could be a reason why the CLA is still pending signing.

Please update the provider documentation with a new data source and add a change log file.

Thanks!

@daemon4d-us
Copy link
Contributor Author

@arybolovlev Thanks for figuring this out. The CLA check is green now. But since I've changed history the PR needs one more approval.

@daemon4d-us
Copy link
Contributor Author

Anyone can take a look one more time?

@BBBmau
Copy link
Contributor

BBBmau commented Dec 4, 2023

Please refer to @arybolovlev's comments, still missing documentation and changelog entry in order for this PR to get merged.

@BBBmau
Copy link
Contributor

BBBmau commented Jan 8, 2024

any update on this? @daemon4d-us

@BBBmau BBBmau self-assigned this Aug 7, 2024
@BBBmau BBBmau added the no-documentation This issue or pull request does not have documentation changes. label Aug 9, 2024
Copy link
Contributor

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after some manual tests as well as adding in documentation with the help of tfplugindocs, thanks again for opening this! @daemon4d-us

@BBBmau BBBmau merged commit e486966 into hashicorp:main Aug 9, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-documentation This issue or pull request does not have documentation changes. size/L waiting-response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants