-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubernetes_server_version data source #2306
Conversation
Hi @torqu3e Does this look better? |
@daemon4d-us |
Hm, something is not working quite good here for me. I have actually signed the CLA, but still appears in Pending state here. |
As far as I can see, 2 out of 3 commits including the initial one were made by a user @dsidorenkonx and you have opened this PR from the username @daemon4d-us. That could be a reason why the CLA is still pending signing. Please update the provider documentation with a new data source and add a change log file. Thanks! |
@arybolovlev Thanks for figuring this out. The CLA check is green now. But since I've changed history the PR needs one more approval. |
Anyone can take a look one more time? |
Please refer to @arybolovlev's comments, still missing documentation and changelog entry in order for this PR to get merged. |
any update on this? @daemon4d-us |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved after some manual tests as well as adding in documentation with the help of tfplugindocs, thanks again for opening this! @daemon4d-us
Description
Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Community Note