Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add expirationSeconds to CertificateSigningRequest #2515

Closed
wants to merge 1 commit into from
Closed

Add expirationSeconds to CertificateSigningRequest #2515

wants to merge 1 commit into from

Conversation

moreinhardt
Copy link
Contributor

@moreinhardt moreinhardt commented Jun 10, 2024 •
edited by BBBmau
Loading

Description

I saw that expirationSeconds wasn't available through this provider.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run="(TestAccKubernetesCertificateSigningRequestV1_basic|TestAccKubernetesCertificateSigningRequestV1_generateName)"'
==> Checking that code complies with gofmt requirements...
go vet ./...
TF_ACC=1 go test "/home/moritz/dev/terraform-provider-kubernetes/add-fields-to-certificate-signing-request/kubernetes" -v -vet=off -run="(TestAccKubernetesCertificateSigningRequestV1_basic|TestAccKubernetesCertificateSigningRequestV1_generateName)" -parallel 8 -timeout 3h
=== RUN   TestAccKubernetesCertificateSigningRequestV1_basic
=== PAUSE TestAccKubernetesCertificateSigningRequestV1_basic
=== RUN   TestAccKubernetesCertificateSigningRequestV1_generateName
=== PAUSE TestAccKubernetesCertificateSigningRequestV1_generateName
=== CONT  TestAccKubernetesCertificateSigningRequestV1_basic
=== CONT  TestAccKubernetesCertificateSigningRequestV1_generateName
--- PASS: TestAccKubernetesCertificateSigningRequestV1_generateName (3.42s)
--- PASS: TestAccKubernetesCertificateSigningRequestV1_basic (3.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-kubernetes/kubernetes	(cached)

Release Note

Release note for CHANGELOG:

`resource/kubernetes_certificate_signing_request_v1`: Add argument `spec.expiration_seconds`

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@moreinhardt moreinhardt requested a review from a team as a code owner June 10, 2024 18:21
@hashicorp-cla-app HashiCorp CLA App
Copy link

hashicorp-cla-app bot commented Jun 10, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@moreinhardt
Copy link
Contributor Author

What do I need to do for this to be merged or as a first step to be looked at by a maintainer?

Also, the acceptance test actions on my fork fail every day which spams me with notifications. Is there any way I can avoid that?

@BBBmau BBBmau mentioned this pull request Jun 28, 2024
Merged
@moreinhardt moreinhardt force-pushed the certificate-signing-request-expiration-seconds branch from 954563c to 09b7100 Compare July 8, 2024 12:51
@moreinhardt moreinhardt force-pushed the certificate-signing-request-expiration-seconds branch from 09b7100 to 62edde0 Compare July 8, 2024 12:58
@BBBmau
Copy link
Contributor

BBBmau commented Jul 16, 2024

Be sure to add a changelog as part of your PR, the steps to do this can be found here: https://github.com/hashicorp/terraform-provider-kubernetes/blob/8ded5dc5338b28f49854d1192f09776ced73e91c/CHANGELOG_GUIDE.md#how-to-use

Deferred Actions workflow can be ignored since they will not pass on PRs from forks. Fix for this is here: #2550

@BBBmau BBBmau mentioned this pull request Jul 19, 2024
Merged
2 tasks
@BBBmau
Copy link
Contributor

BBBmau commented Jul 24, 2024

Seems like I am unable to make edits on this PR. Since this only needs a changelog entry to be merged and sufficient time has passed with no response, I'll be closing this PR to open a new one with the required changelog entry.

@BBBmau BBBmau closed this Jul 24, 2024
@BBBmau BBBmau mentioned this pull request Jul 24, 2024
Merged
2 tasks
@moreinhardt
Copy link
Contributor Author

Sorry for not responding, I was offline during those weeks.

Thank you for following up! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BBBmau BBBmau BBBmau left review comments

@bateller bateller bateller approved these changes

@JaylonmcShan03 JaylonmcShan03 Awaiting requested review from JaylonmcShan03

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moreinhardt @BBBmau @bateller