Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add values in acceptance_tests_kind.yaml workflow to allow PRs from forks to run #2555

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented Jul 19, 2024

Description

adds explicit values to allow acceptance_kind.yaml to be ran on forks coming from PRs. A similar change was done on #2550 this however keeps the vars so that we can still change the values used in scheduled triggers. the explicit value added is meant to only be used on PRs from forks.

failures can be seen across multiple PRs such as:
#2515
#2473
#2494

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@BBBmau BBBmau requested a review from a team as a code owner July 19, 2024 21:07
@BBBmau BBBmau merged commit e1c4348 into main Jul 21, 2024
10 checks passed
@BBBmau BBBmau deleted the fix-kind-acceptance-test branch July 21, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants