-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking change: SDK v2 #42
Conversation
146f270
to
a808802
Compare
Absolute paths are now required for local filesystem resources created and checked during tests.
a808802
to
7bb1fcc
Compare
This PR has been repurposed as the SDKv2 upgrade, as that supersedes the earlier upgrade to binary testing. |
The acceptance test failure is due to a bug introduced in Terraform 0.13, in which data sources with references to resources get evaluated too early. With Terraform 0.11.0 and 0.12.20, the following config produces a file called
With Terraform 0.13.3,
I think this is fixed in hashicorp/terraform#26458, not yet released. In any case, the problem is fixed in
@paultyng, I'm happy with (1), but if we want to get this merged soon then (3) is probably more sensible. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
closes #38
Upgrade SDK to v2.0.3
Enable binary acceptance test driver with reattach testing.
Absolute paths are now required for local filesystem resources created and checked during tests; use temporary directories for this purpose.