Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add headers to provider #203

Merged
merged 5 commits into from
Apr 1, 2021
Merged

Add headers to provider #203

merged 5 commits into from
Apr 1, 2021

Conversation

Mongey
Copy link
Contributor

@Mongey Mongey commented Mar 9, 2021

No description provided.

@Lucretius Lucretius mentioned this pull request Mar 29, 2021
Closed
@cgbaker cgbaker self-assigned this Mar 31, 2021
@cgbaker cgbaker added this to the 1.4.14 milestone Mar 31, 2021
@Mongey Mongey marked this pull request as ready for review March 31, 2021 18:16
@Mongey
Copy link
Contributor Author

Mongey commented Mar 31, 2021

I think I probably meant to add tests/docs, and then forgot to follow back up 😅

@cgbaker
Copy link
Contributor

cgbaker commented Mar 31, 2021

@Mongey , i don't mind picking this up and adding tests/docs.

@cgbaker
Copy link
Contributor

cgbaker commented Mar 31, 2021

we were looking at doing a release soon and there has been some request for this PR.

cgbaker added a commit to Mongey/terraform-provider-nomad that referenced this pull request Apr 1, 2021
@cgbaker
changelog for hashicorp#203
96eb09a
@cgbaker cgbaker requested a review from lgfa29 April 1, 2021 13:13
@cgbaker
Copy link
Contributor

cgbaker commented Apr 1, 2021

thanks for the pr, @Mongey ; i've added some tests and documentation.

@cgbaker cgbaker requested a review from jrasell April 1, 2021 13:14
jrasell
jrasell previously approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I am not sure what is causing the CI failure. I believe go mod tidy could be run to clean out some entries in the sum file, but this isn't critical.

@cgbaker
Copy link
Contributor

cgbaker commented Apr 1, 2021

i broke something in main.go when i change one of the returns, fixing it now

@cgbaker cgbaker merged commit 5383a32 into hashicorp:main Apr 1, 2021
cgbaker added a commit that referenced this pull request Apr 1, 2021
@cgbaker
changelog for #203
fdadf3c
@lgfa29 lgfa29 mentioned this pull request Apr 19, 2021
Closed
@jrasell jrasell mentioned this pull request May 10, 2021
Closed
This was referenced May 10, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasell jrasell jrasell left review comments

@lgfa29 lgfa29 Awaiting requested review from lgfa29

Assignees

@cgbaker cgbaker

Labels
stage/accepted theme/provider type/enhancement
Projects
None yet
Milestone
1.4.14
Development

Successfully merging this pull request may close these issues.
3 participants
@Mongey @cgbaker @jrasell