Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/nomad_job: switch to HCL2 by default #343

Merged
merged 3 commits into from
Jul 11, 2023
Merged

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Jul 10, 2023

Parsing with HCL2 is the default behaviour of the Nomad CLI and so this change aims to make their behaviour the same.

The new hcl1 attribute is provided for backwards compatibility to also match the Nomad CLI, which has the -hcl1 flag.

lgfa29 added 2 commits July 10, 2023 16:48
Parsing with HCL2 is the default behaviour of the Nomad CLI and so this
change aims to make their behaviour the same.

The new `hcl1` attribute is provided for backwards compatibility to also
match the Nomad CLI, which has the `-hcl1` flag.
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from upgrade-sdkv2 to main July 11, 2023 15:05
Co-authored-by: James Rasell <jrasell@users.noreply.github.com>
@lgfa29 lgfa29 merged commit 247eead into main Jul 11, 2023
@lgfa29 lgfa29 deleted the job-hcl2-default branch July 11, 2023 15:13
@lgfa29 lgfa29 added this to the 2.0.0 milestone Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants