-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix delete default namespace #73
Conversation
02486d4
to
fc111aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manually tested, works great.
minor nitpicks, but lgtm!
return nil | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-Authored-By: Chris Baker <1675087+cgbaker@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Currently if you reference the
default
namespace in your configuration Terraform will fail to destroy it because the API will return a 500 error:This error can prevent other resources from being destroyed if they depend on this namespace.
This PR prevents this error from happening by not trying to delete the
default
namespace. Instead it resets thequota
anddescription
attributes to their initial values.Fixes #72 .