-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
function/rfc3339_parse
: Add RFC3339 parsing function
#280
Conversation
function/rfc3339_parse
: Add RFC3339 parsing provider defined function
function/rfc3339_parse
: Add RFC3339 parsing provider defined functionfunction/rfc3339_parse
: Add RFC3339 parsing function
terraform-plugin-docs has been updated on main 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Ref: #217
Terraform core refs: hashicorp/terraform#29694, hashicorp/terraform#31751, hashicorp/terraform#25802, hashicorp/terraform#33538
This PR introduces a new provider-defined function for parsing RFC3339 timestamps:
Notes
(time).Zone()
zone_name
is not directly related tozone_offset
, and would always be"UTC"
or""
zone_offset
is valid and a part of the RFC3339 string. Thetime.Time
package returns this offset in seconds east of UTC, which may be confusing to users (but potentially necessary in this format, since time zone offsets aren't necessarily in whole hours 😖 ).(time).ParseInLocation
function_
to follow the convention of the repository. I can also refactor all the files in this provider to match the other accepted pattern of:*_function.go
*_resource.go