Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include custom_metadata support for entity aliases #1235

Merged
merged 13 commits into from
Dec 13, 2021
Merged

Include custom_metadata support for entity aliases #1235

merged 13 commits into from
Dec 13, 2021

Conversation

vinay-gopalan
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #4074

Release note for CHANGELOG:

resource/vault_identity_entity_alias: Add `custom_metadata` support for entity aliases.

Output from acceptance testing:

$ make testacc TESTARGS='-v -run TestAccIdentityEntityAlias'
=== RUN   TestAccIdentityEntityAlias
--- PASS: TestAccIdentityEntityAlias (2.43s)
=== RUN   TestAccIdentityEntityAlias_Update
--- PASS: TestAccIdentityEntityAlias_Update (3.15s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault
...

@vinay-gopalan vinay-gopalan marked this pull request as ready for review November 23, 2021 00:23
benashz
benashz requested changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits/questions. Also I think we need to update the documentation.

vault/resource_identity_entity_alias.go Outdated Show resolved Hide resolved
vault/resource_identity_entity_alias_test.go Outdated Show resolved Hide resolved
vault/resource_identity_entity_alias_test.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/M and removed size/S labels Nov 29, 2021
@vinay-gopalan vinay-gopalan changed the title [VAULT-4074] Include custom_metadata support for entity aliases Include custom_metadata support for entity aliases Dec 6, 2021
benashz
benashz reviewed Dec 6, 2021
View reviewed changes
vault/resource_identity_entity_alias.go Outdated Show resolved Hide resolved
vault/resource_identity_entity_alias_test.go Outdated Show resolved Hide resolved
@benashz benashz added this to the 3.1.0 milestone Dec 6, 2021
vinay-gopalan and others added 2 commits December 6, 2021 15:39
@vinay-gopalan
add test that updates alias and removes metadata
b9084fe
@vinay-gopalan @benashz
remove extra whitespace
583565d 
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
@vinay-gopalan vinay-gopalan requested a review from benashz December 6, 2021 23:40
benashz
benashz reviewed Dec 10, 2021
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

A few minor suggestions and nits to resolve.

Also, I suggest adding a TODO reminder to add back the empty custom_metadata updates tests.

vault/resource_identity_entity_alias_test.go Outdated Show resolved Hide resolved
vault/resource_identity_entity_alias_test.go Outdated Show resolved Hide resolved
vault/resource_identity_entity_alias.go Outdated Show resolved Hide resolved
vault/resource_identity_entity_alias.go Outdated Show resolved Hide resolved
vault/resource_identity_entity_alias.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@vinay-gopalan
Copy link
Contributor Author

@benashz Responded to your feedback in latest commit 86de875

benashz
benashz approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinay-gopalan vinay-gopalan merged commit e71e2f3 into main Dec 13, 2021
@vinay-gopalan vinay-gopalan deleted the feature/entity-alias-metadata branch December 13, 2021 20:29
@vinay-gopalan vinay-gopalan mentioned this pull request Dec 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vinay-gopalan @benashz