Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for custom metadata field in Kubernetes auth backend config #1328

Closed
wants to merge 1 commit into from
Closed

Support for custom metadata field in Kubernetes auth backend config #1328

wants to merge 1 commit into from

Conversation

chongyangshi
Copy link

This change accompanies monzo/vault-plugin-auth-kubernetes#1, which adds a new config flag enable_custom_metadata_from_annotations to the Kubernetes auth plugin. If enabled this will cause the auth plugin to read service account annotations in Kubernetes prefixed with vault.hashicorp.com/auth-metadata/ as auth metadata in Vault.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

* `resource/vault_kubernetes_auth_backend_config`: Add `enable_custom_metadata_from_annotations` config parameter to k8s auth backend (PR link TODO)
* `data/vault_kubernetes_auth_backend_config`: Add `enable_custom_metadata_from_annotations` config parameter to k8s auth backend (PR link TODO)

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
TODO
...

Support for custom metadata field in Kubernetes auth backend config
31bdbf2 
This change accompanies monzo/vault-plugin-auth-kubernetes#1, which
adds a new config flag to the Kubernetes auth plugin ,
which if enabled will cause the auth plugin to read service account annotations in
Kubernetes prefixed with vault.hashicorp.com/auth-metadata/ as auth metadata in Vault.
@hashicorp-cla
Copy link

hashicorp-cla commented Feb 1, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@chongyangshi
Copy link
Author

Not ready to PR yet, will re-open when ready, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chongyangshi @hashicorp-cla