Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Test against vault-enterprise 1.10.3-ent #1461

Merged
merged 50 commits into from
May 21, 2022
Merged

CI: Test against vault-enterprise 1.10.3-ent #1461

merged 50 commits into from
May 21, 2022

Conversation

benashz
Copy link
Contributor

@benashz benashz commented May 17, 2022 •
edited
Loading

This PR moves us from CircleCI to GitHub Actions and allows us to run all acceptance tests against Vault Enterprise

Additional fixes:

  • Fix up broken enterprise tests
  • Add support for testing against Postgres
  • Fix a regression introduced in v3.5.0 which inadvertently removed the the disable_escaping feature from some db engines
  • Fix bogus quota test that caused the tests to fail

Closes #1463

@benashz
CI: Test against vault-enterprise 1.10.3-ent
8ec9810 
- run enterprise acceptance tests
@github-actions github-actions bot added size/S and removed size/XS labels May 17, 2022
@github-actions github-actions bot added size/M and removed size/S labels May 17, 2022
@github-actions github-actions bot added size/L and removed size/M labels May 18, 2022
@benashz benashz force-pushed the VAULT-5853/test-against-enterprise branch from ee5bd8a to 2dd1462 Compare May 18, 2022 23:35
@github-actions github-actions bot added size/XL and removed size/L labels May 19, 2022
@benashz benashz requested a review from vinay-gopalan May 20, 2022 18:48
@benashz benashz mentioned this pull request May 20, 2022
Closed
vinay-gopalan
vinay-gopalan reviewed May 20, 2022
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks great! Couple of nits and questions :)

codegen/generate.go Show resolved Hide resolved
vault/resource_kmip_secret_backend.go Show resolved Hide resolved
vault/resource_quota_lease_count_test.go Outdated Show resolved Hide resolved
@benashz benashz merged commit 301c7ca into main May 21, 2022
@benashz benashz deleted the VAULT-5853/test-against-enterprise branch May 21, 2022 00:34
@benashz benashz added this to the 3.7.0 milestone Jun 15, 2022
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
@benashz
CI: move to GHA, test against vault-enterprise 1.10.3-ent (hashicorp#…
d528269 
…1461)

Move from CircleCI to GitHub Actions. Run all acceptance tests
against Vault Enterprise.

Additional fixes:
- Fix up broken enterprise tests
- Add support for testing against Postgres
- Fix a regression introduced in v3.5.0 which inadvertently removed 
  the the `disable_escaping` feature from some db engines
- Fix bogus quota test that caused the tests to fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees
No one assigned
Labels
dependencies size/XL
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.

Argument named "disable_escaping" is not expected
2 participants
@benashz @vinay-gopalan