Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth/gcp: adds custom_endpoint parameter to backend config #1482

Merged
merged 10 commits into from
Jun 8, 2022
Merged

auth/gcp: adds custom_endpoint parameter to backend config #1482

merged 10 commits into from
Jun 8, 2022

Conversation

austingebauer
Copy link
Contributor

@austingebauer austingebauer commented Jun 3, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes: N/A

Release note for CHANGELOG:

* `resource/vault_gcp_auth_backend`: Adds support for the `custom_endpoint` parameter on backend config (#1482)

Output from acceptance testing:

$ make testacc TESTARGS='-count=1 -run=TestGCPAuth'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test -v -count=1 -run=TestGCPAuth -timeout 30m ./...
=== RUN   TestGCPAuthBackend_pathRegex
=== RUN   TestGCPAuthBackend_pathRegex/no_nesting
=== RUN   TestGCPAuthBackend_pathRegex/nested
=== RUN   TestGCPAuthBackend_pathRegex/nested_with_double_'role'
--- PASS: TestGCPAuthBackend_pathRegex (0.00s)
    --- PASS: TestGCPAuthBackend_pathRegex/no_nesting (0.00s)
    --- PASS: TestGCPAuthBackend_pathRegex/nested (0.00s)
    --- PASS: TestGCPAuthBackend_pathRegex/nested_with_double_'role' (0.00s)
=== RUN   TestGCPAuthBackendRole_basic
=== RUN   TestGCPAuthBackendRole_basic/simple_backend_path
=== RUN   TestGCPAuthBackendRole_basic/nested_backend_path
--- PASS: TestGCPAuthBackendRole_basic (4.85s)
    --- PASS: TestGCPAuthBackendRole_basic/simple_backend_path (2.60s)
    --- PASS: TestGCPAuthBackendRole_basic/nested_backend_path (2.24s)
=== RUN   TestGCPAuthBackendRole_gce
--- PASS: TestGCPAuthBackendRole_gce (1.13s)
=== RUN   TestGCPAuthBackend_basic
--- PASS: TestGCPAuthBackend_basic (1.89s)
=== RUN   TestGCPAuthBackend_import
--- PASS: TestGCPAuthBackend_import (1.32s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     10.082s

@github-actions github-actions bot added size/L and removed size/M labels Jun 3, 2022
@austingebauer austingebauer requested a review from benashz June 3, 2022 20:30
benashz
benashz reviewed Jun 6, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I have a few suggestions related to config lifecycle handling.

vault/resource_gcp_auth_backend.go Outdated Show resolved Hide resolved
vault/resource_gcp_auth_backend.go Outdated Show resolved Hide resolved
vault/resource_gcp_auth_backend_test.go Show resolved Hide resolved
benashz
benashz reviewed Jun 6, 2022
View reviewed changes
vault/resource_gcp_auth_backend_test.go Outdated Show resolved Hide resolved
vault/resource_gcp_auth_backend_test.go Outdated Show resolved Hide resolved
austingebauer and others added 5 commits June 7, 2022 13:15
@austingebauer @benashz
Update vault/resource_gcp_auth_backend_test.go
f90819b 
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
@austingebauer @benashz
Update vault/resource_gcp_auth_backend.go
fa7300e 
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
@austingebauer @benashz
Update vault/resource_gcp_auth_backend_test.go
edd9a13 
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
@austingebauer @benashz
Update vault/resource_gcp_auth_backend_test.go
a214efe 
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
@austingebauer
return custom endpoint schema from function
1f5b8ea
@austingebauer austingebauer requested a review from benashz June 7, 2022 21:12
@austingebauer
Copy link
Contributor Author

Thanks for the feedback, @benashz! I've applied your suggestions and ran the tests again. Lmk your thoughts.

benashz
benashz approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few minor suggestions/nits then +1

vault/resource_gcp_auth_backend.go Outdated Show resolved Hide resolved
vault/resource_gcp_auth_backend_test.go Show resolved Hide resolved
vault/resource_gcp_auth_backend_test.go Show resolved Hide resolved
austingebauer and others added 2 commits June 8, 2022 09:00
@austingebauer @benashz
Update vault/resource_gcp_auth_backend.go
ad8af4b 
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
@austingebauer
terraform format test config
f298140
@austingebauer austingebauer merged commit 76c7ed2 into release/vault-next Jun 8, 2022
@austingebauer austingebauer deleted the resource/auth_gcp_custom_endpoints branch June 8, 2022 17:31
@benashz benashz added this to the 3.8.0 milestone Jun 14, 2022
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
@austingebauer @benashz
auth/gcp: adds custom_endpoint parameter to backend config (hashicorp…
9ecb462 
…#1482)

* auth/gcp: adds custom_endpoint parameter to backend config

* change custom_endpoint to a resource block

* updates docs with example and 1.11+ mention

* Update vault/resource_gcp_auth_backend_test.go

Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>

* Update vault/resource_gcp_auth_backend.go

Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>

* Update vault/resource_gcp_auth_backend_test.go

Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>

* Update vault/resource_gcp_auth_backend_test.go

Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>

* return custom endpoint schema from function

* Update vault/resource_gcp_auth_backend.go

Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>

* terraform format test config

Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

@vinay-gopalan vinay-gopalan Awaiting requested review from vinay-gopalan

Assignees
No one assigned
Labels
documentation feature-parity resource/gcp_auth size/L
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@austingebauer @benashz