Add Managed Keys support to TFVP #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benashz
reviewed
Jun 30, 2022
benashz
reviewed
Aug 2, 2022
| @@ -217,6 +217,56 @@ func TestResourceMount_ExternalEntropyAccess(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestResourceMountMangedKeys(t *testing.T) { | |||
There was a problem hiding this comment.
Ideally we could test this field in its own step, but I suppose that's ok.
Can you add a import test step.
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
…p/terraform-provider-vault into VAULT-4820/managed-keys-support
benashz
reviewed
Aug 12, 2022
| }, | ||
| Config: testManagedKeysConfig_updated(name0), | ||
| Check: resource.ComposeAggregateTestCheckFunc( | ||
| resource.TestCheckResourceAttr(resourceName, "aws.#", "1"), |
There was a problem hiding this comment.
This doesn't really prove that the a delete/create operation took place. In the end you should end up with a new UUID that is different from the original created by the provider and the one created manually.
There was a problem hiding this comment.
Tracking this task in a separate Jira. Thanks for the callout!
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
marcboudreau
pushed a commit
to marcboudreau/terraform-provider-vault
that referenced
this pull request
Nov 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Managed keys to the PKI Secret Engine and adds a new resource
vault_managed_keysto the TFVP.Output from acceptance testing: