-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Consul secrets engine enhancements #1518
Add support for Consul secrets engine enhancements #1518
Conversation
f7ab399
to
b33e7a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. I added a few comments/suggestions. Also I think we need to update the website docs.
Looks like the build is failing when testing against Vault-1.10, we will probably need special case some of the tests to account for feature differences between 1.10 and 1.11. |
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
…consul_policies or policies is returned by Vault when building the resourcedata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Couple of nits and questions but PR is looking great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for all of the help!! |
…orp#1518) * Add support for Vault 1.11 Consul secrets engine's new features * Update test coverage for vault 1.10 and vault 1.11 * Update docs to reflect new parameters * Add TF_VAULT_VERSION to the README and GHA workflow Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
This adds supports for service identities and node identities in Consul and for the ability to bootstrap the Consul ACL system by writing the secrets engine config without a token.
Bootstrapping example:
Identities example:
Community Note
Release note for CHANGELOG:
Output from acceptance testing: