Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Azure example to the doc #1534

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Add Azure example to the doc #1534

merged 2 commits into from
Aug 1, 2022

Conversation

yhyakuna
Copy link
Contributor

@yhyakuna yhyakuna commented Jul 15, 2022 •
edited
Loading

Based on the request, I'm adding a configuration example for Azure blob to the vault_raft_snapshot_agent_config doc.

🎟️ Asana task


Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@yhyakuna yhyakuna self-assigned this Jul 15, 2022
@github-actions github-actions bot added size/XS and removed size/S labels Jul 15, 2022
@yhyakuna yhyakuna requested a review from benashz July 21, 2022 16:14
benashz
benashz reviewed Jul 21, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue with the interval_seconds, does not match comment. Also I am guessing that a snapshot ever minute might be excessive?

website/docs/r/raft_snapshot_agent_config.html.md Outdated Show resolved Hide resolved
@yhyakuna @benashz
Update website/docs/r/raft_snapshot_agent_config.html.md
223defd 
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
@yhyakuna yhyakuna requested a review from martinhristov90 July 26, 2022 18:47
benashz
benashz approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benashz benashz added this to the 3.9.0 milestone Jul 29, 2022
@benashz benashz merged commit 5838b71 into main Aug 1, 2022
@benashz benashz deleted the raft-storage-config-example branch August 1, 2022 15:10
@benashz benashz modified the milestones: 3.9.0, 3.8.1 Aug 2, 2022
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
@yhyakuna @benashz
Add Azure example to the doc (hashicorp#1534)
1645259 
* Add Azure example requested by a customer

* Update website/docs/r/raft_snapshot_agent_config.html.md

Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

@martinhristov90 martinhristov90 Awaiting requested review from martinhristov90

Assignees

@yhyakuna yhyakuna

Labels
documentation size/XS
Projects
None yet
Milestone
3.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@yhyakuna @benashz