Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make password_policy conflict with the formatter field #1557

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Make password_policy conflict with the formatter field #1557

merged 2 commits into from
Aug 1, 2022

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Jul 29, 2022 •
edited
Loading

Previously it was possible to configure password_policy together with
formatter in the vault_ad_secret_backend resource. These
fields should now be mutually exclusive.

Output from acceptance testing:

$ go tool test2json -t /private/var/folders/7k/my8v1wcx7ml49fkngscxv4bw0000gp/T/GoLand/___1TestADSecretBackend_in_github_com_hashicorp_terraform_provider_vault_vault.test -test.v -test.paniconexit0 -test.run ^\QTestADSecretBackend\E$
=== RUN   TestADSecretBackend
--- PASS: TestADSecretBackend (1.94s)
PASS

Process finished with the exit code 0

@benashz
Make password_policy conflict with the formatter and length fields
ec08fd9 
Previously it was possible to configure password_policy together with
formatter or length in the vault_ad_secret_backend resource. These
fields should now be mutually exclusive.
@benashz benashz requested a review from vinay-gopalan July 29, 2022 20:48
@benashz benashz mentioned this pull request Jul 29, 2022
Closed
vinay-gopalan
vinay-gopalan reviewed Jul 29, 2022
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR's looking great! Though it looks like the AD tests are failing in CI due to invalid credentials

@benashz
Copy link
Contributor Author

benashz commented Jul 29, 2022

PR's looking great! Though it looks like the AD tests are failing in CI due to invalid credentials

Thanks, looking at it now.

@benashz
Hold off on making length conflict with password_policy
969a4dc 
- revert openldap addition until we have a proper image test against.
@benashz benashz changed the title Make password_policy conflict with the formatter and length fields Make password_policy conflict with the formatter field Aug 1, 2022
@benashz benashz requested a review from vinay-gopalan August 1, 2022 15:01
@benashz benashz added this to the 3.9.0 milestone Aug 1, 2022
vinay-gopalan
vinay-gopalan approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benashz benashz merged commit 9df0538 into main Aug 1, 2022
@benashz benashz deleted the VAULT-7344/fix-ad-password-policy-exclusions branch August 1, 2022 17:51
@benashz benashz modified the milestones: 3.9.0, 3.8.1 Aug 2, 2022
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
@benashz
Make password_policy conflict with the formatter field (hashicorp#1557)
d14c1a1 
Make password_policy conflict with the formatter field (hashicorp#1557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees
No one assigned
Labels
documentation size/L
Projects
None yet
Milestone
3.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@benashz @vinay-gopalan