Add bootstrap field to Consul backend resources

[robmonte]

This change adds a new field named bootstrap to Consul backend resources. This will be to designate when a Consul resource is the holder of the Consul ACL bootstrap token. This field has some rules when used in combination with the token field.

If a resource is used to bootstrap Consul by not providing a token, then bootstrap must be set to true:

resource "vault_consul_secret_backend" "consul" {
  path        = "consul"
  address     = "http://127.0.0.1:8500"
  bootstrap = true
}

When creating a backend resource, the absence of both bootstrap = true and a token generates the following error:

Error: field `bootstrap` must be set to true when `token` is unspecified

When creating a backend resource, the presence of both bootstrap = true and a token will give a different error:

Error: field `bootstrap` must be set to false when `token` is specified

Release note for CHANGELOG:

BUG FIXES:
* Add 'bootstrap' field to Consul backend resources to help users identify them easier

Output from acceptance testing:

❯ make testacc TESTARGS='-run=^TestConsulSecretBackend'            
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test -v -run=^TestConsulSecretBackend -timeout 30m ./...

2022/08/10 23:08:54 [INFO] Using Vault token with the following policies: root
=== RUN   TestConsulSecretBackendRole
--- PASS: TestConsulSecretBackendRole (2.77s)
=== RUN   TestConsulSecretBackendRoleNameFromPath
--- PASS: TestConsulSecretBackendRoleNameFromPath (0.00s)
=== RUN   TestConsulSecretBackendRoleBackendFromPath
--- PASS: TestConsulSecretBackendRoleBackendFromPath (0.00s)
=== RUN   TestConsulSecretBackend
--- PASS: TestConsulSecretBackend (4.29s)
=== RUN   TestConsulSecretBackend_Bootstrap
--- PASS: TestConsulSecretBackend_Bootstrap (4.30s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     11.771s

 

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

[benashz]

A few nits, suggestions to address then 👍

[benashz]

LGTM!