Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis - Add TFVP Support #1659

Merged
merged 5 commits into from
Nov 9, 2022
Merged

Redis - Add TFVP Support #1659

merged 5 commits into from
Nov 9, 2022

Conversation

Zlaticanin
Copy link
Contributor

@Zlaticanin Zlaticanin commented Nov 2, 2022 •
edited
Loading

Release note for CHANGELOG:

feat: Add TFVP support for the Redis Database Plugin

Output from acceptance testing:

$ make testacc TESTARGS='-v -run=TestAccDatabaseSecretBackendConnection_redis'
2022/11/01 16:01:26 [INFO] Using Vault token with the following policies: root
=== RUN   TestAccDatabaseSecretBackendConnection_redis
--- PASS: TestAccDatabaseSecretBackendConnection_redis (1.15s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     (cached)
...

@Zlaticanin Zlaticanin marked this pull request as ready for review November 2, 2022 17:01
benashz
benashz reviewed Nov 3, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I had a few minor suggestions/comments.

vault/resource_database_secret_backend_connection.go Show resolved Hide resolved
vault/resource_database_secret_backend_connection_test.go Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Zlaticanin Zlaticanin requested a review from benashz November 4, 2022 22:52
benashz
benashz approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits still to address, otherwise looks great!

vault/resource_database_secret_backend_connection.go Outdated Show resolved Hide resolved
vault/resource_database_secret_backend_connection.go Outdated Show resolved Hide resolved
website/docs/r/database_secret_backend_connection.md Outdated Show resolved Hide resolved
website/docs/r/database_secrets_mount.md Outdated Show resolved Hide resolved
vinay-gopalan
vinay-gopalan approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@benashz benashz mentioned this pull request Nov 9, 2022
Closed
@Zlaticanin Zlaticanin merged commit 95c964e into main Nov 9, 2022
@Zlaticanin Zlaticanin deleted the redis-tfvp-support branch November 9, 2022 16:14
@Zlaticanin Zlaticanin mentioned this pull request Nov 14, 2022
Closed
@benashz benashz added this to the 3.11.0 milestone Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees
No one assigned
Labels
documentation size/L
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Zlaticanin @benashz @vinay-gopalan