Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for importing the PKI CRL config #1710

Merged
merged 10 commits into from
Jan 3, 2023
Merged

Add support for importing the PKI CRL config #1710

merged 10 commits into from
Jan 3, 2023

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Dec 22, 2022

  • Adapt tests to support older vault versions
  • Make some API data and schema set operations simpler
  • Fix broken build

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@benashz
Add support for importing the PKI CRL config
f7514f3 
- Adapt tests to support older vault versions
- Make some API data and schema set operations simpler
- Fix broken build
@benashz benashz added this to the 3.12.0 milestone Dec 23, 2022
vinay-gopalan
vinay-gopalan approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is looking great! Nice style precedent that we should probably use going forward for setting up tests wherever we can 😄

Had one potential fix for one of the test pre-checks, but looks good to me otherwise

@benashz benashz force-pushed the VAULT-12325/add-import-support-for-pki-crl-config branch from 7fdfb90 to b1c4626 Compare December 23, 2022 15:39
@benashz
Debug GH api rate-limit issues
b58dfa4 
Cache GHOrgResponse's using a sync.Map{}
@benashz
Dump GH request headers
2b2a9dd
@benashz
More GH rate-limit debugging
f7fbc19 
- Test out deps caching to speed things up
- Build with go-1.19.4
@benashz
Dump go env
cdd4ea7
@benashz
Fix go cache paths
a709389
@benashz
Drop build cache, set GITHUB_TOKEN in build
f070e6e 
- other fixes
@benashz benashz merged commit 0766787 into main Jan 3, 2023
@benashz benashz deleted the VAULT-12325/add-import-support-for-pki-crl-config branch January 3, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees
No one assigned
Labels
dependencies documentation size/XL
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@benashz @vinay-gopalan