Update k8s-auth config to support unsetting the K8s CA Cert #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to vault-1.9.3, the k8s-auth engine would store the K8S CA cert in its configuration if Vault was running in K8s. Post vault-1.9.3, this behaviour was changed to longer store the K8s CA cert in config. That change confuses TFVP since the kubernetes_ca_cert field can no longer be computed. This fix detects and remedies by adding the ability to "unset" the CA cert in the case where we are provisioning vault-1.9.3+. It should also clean up any K8s CA cert that was left behind after upgrading from any Vault prior to 1.9.3.
raymonstah
approved these changes
Sep 12, 2023
benashz
deleted the
VAULT-19582/k8s-auth-config-support-unsetting-ca-cert
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to vault-1.9.3, the k8s-auth engine would store the K8S CA cert in its configuration if Vault was running in K8s. Post vault-1.9.3, this behaviour was changed to longer store the K8s CA cert in config. That change confuses TFVP since the kubernetes_ca_cert field can no longer be computed. This fix detects and remedies by adding the ability to "unset" the CA cert in the case where we are provisioning vault-1.9.3+. It should also clean up any K8s CA cert that was left behind after upgrading from any Vault prior to 1.9.3.