auth_login: enforce empty client token #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benashz
force-pushed
the
VAULT-20288/auth-login-expunge-env-client-token
branch
2 times, most recently
from
7f794f2 to
42c3a97
Compare
2 tasks
|
Tested and approved with my use case described in my closed PR #2026 : excited to see release 3.21.0. |
alex-ikse
approved these changes
Sep 26, 2023
other fixes: - parallelize AuthLogin tests - ensure VAULT_TOKEN is not set from the test make targets
benashz
force-pushed
the
VAULT-20288/auth-login-expunge-env-client-token
branch
from
42c3a97 to
a0b9d2e
Compare
benashz
changed the title
alex-ikse
approved these changes
Sep 26, 2023
fairclothjm
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a failure when an
auth_loginis specified and a vault token is picked up from the runtime/execution environment. In the meantime the workaround is to ensure thatVAULT_TOKENis unset, and there exists no vault token on disk e.g:~/.vault-tokenother fixes:
Relates to hashicorp/vault#23216 #2026